On 02/10/2014 04:49 PM, Michał Mirosław wrote:
On Mon, Feb 10, 2014 at 09:12:31AM -0700, Shuah Khan wrote:
Change cb710-mmc platform driver to register pm ops using dev_pm_ops instead
of legacy pm_ops. .pm hooks call existing legacy suspend and resume interfaces
by passing in the right pm state.
[all the patch cut]
Aaah, a bit mechanical - this change, isn't it?
Yes :)
The suspend/resume callbacks just clears IRQ mask in the device in case it
got undefined during sleep state. So the proper change here is to squash all
the functions in one, and point all of the hooks to it.
With the change you have my ack.
BTW, you could move cb710_mmc_suspend() (or whatever you'll call it) to one
ifdef block with cb710_mmc_dev_pm_ops.
It makes perfect sense to squash suspend and resume. Thanks for the
review. Code looks lot simpler now. Will send v2 patch shortly.
-- Shuah
--
Shuah Khan
Senior Linux Kernel Developer - Open Source Group
Samsung Research America(Silicon Valley)
shuah.kh@xxxxxxxxxxx | (970) 672-0658
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
