Re: [PATCH] mmc-utils: add eMMC 5.0 FFU support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 23, 2014 at 11:28 AM, Chris Ball <chris@xxxxxxxxxx> wrote:
> Hi Grant,
>
> On Thu, Jan 23 2014, Grant Grundler wrote:
>> You can directly pull into a local branch/review with:
>>     git fetch https://chromium.googlesource.com/chromiumos/third_party/mmc-utils
>> refs/changes/21/179621/2 && git cherry-pick FETCH_HEAD
>
> Thanks, that worked fine.  Now I'm seeing:
>
> cc  -Wall -Werror -Wuninitialized -Wundef -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2 -g -O2 -Wp,-MMD,./.mmc_cmds.o.d,-MT,mmc_cmds.o -c mmc_cmds.c
> mmc_cmds.c: In function ‘do_firmware_update’:
> mmc_cmds.c:1201:53: error: macro "strncmp" requires 3 arguments, but only 2 given
> if (strncmp(argv[4], "--I_want_to_destroy_my_drive")) {


Sorry - I fixed that yesterday but apparently didn't update the "git
format-patch" output I used to send the patch out today. /o\

Will respin ASAP. and resend. *sigh*

apologies,
grant

>                                                    ^
> mmc_cmds.c:1201:6: error: the address of ‘strncmp’ will always evaluate as ‘true’ [-Werror=address]
> if (strncmp(argv[4], "--I_want_to_destroy_my_drive")) {
>     ^
> mmc_cmds.c:1290:4: error: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘size_t’ [-Werror=format=]
>     fwsize, fwfilename, ret);
>     ^
> cc1: all warnings being treated as errors
> make: *** [mmc_cmds.o] Error 1
>
> --
> Chris Ball   <chris@xxxxxxxxxx>   <http://printf.net/>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux