Hi Chris,
Hi Chris,
Could we progress this patch ?
Fixes a loop that never terminates if the SD card is bad in just the right way.
Philip
From Neal Buckendahl <>
Subject [PATCH] mmc: host: sdhci: prevent mmcqd from becoming locked on mmc timeout
Date Wed, 13 Nov 2013 20:22:54 -0800
fixed a condition where device issues a status cmd to sdcard but no response
comes from sdcard. The sdhci irq fires and we hit a timeout case which calls
sdhci_finish_data(). sdhci_finish_data eventually attempt to reset controller
and issues stop cmd. However mmcdq is wait_for_completion(&mrq->completion)
in function mmc_wait_for_req_done which never occurs.
Signed-off-by: Neal Buckendahl <nealb001@xxxxxxxxx>
Signed-off-by: Narayanan Gopalakrishnan <narayan.1979@xxxxxxxxx>
Signed-off-by: Philip Rakity <prakity@xxxxxxxxxx>
---
drivers/mmc/host/sdhci.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 6785fb1..21620d2 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -973,6 +973,11 @@ static void sdhci_finish_data(struct sdhci_host *host)
if (data->error) {
sdhci_reset(host, SDHCI_RESET_CMD);
sdhci_reset(host, SDHCI_RESET_DATA);
+ if (data->error == -ETIMEDOUT) {
+ host->mrq->cmd->error = -ETIMEDOUT;
+ tasklet_schedule(&host->finish_tasklet);
+ WARN_ON(1);
+ }
}
sdhci_send_command(host, data->stop);
--
1.7.10.4
-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information. Any unauthorized review, use, disclosure or distribution
is prohibited. If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
