Re: [PATCH 2/4] Moving of_init_opp_table

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 17, 2013 at 05:17:29PM -0800, John Tobias wrote:
>     Moving of_init_opp_table from mach-imx6q.c to imx6q-cpufreq.c in order to avoid adding it to mach-imx6sl.c.
>     Just incase the cpu frequency scaling is enabled on iMX6SL.

Drop the leading spaces and wrap the lines around 72 column.

> 
> Signed-off-by: John Tobias <john.tobias.ph@xxxxxxxxx>
> ---
>  drivers/cpufreq/imx6q-cpufreq.c | 5 +++++

For this patch, a proper patch subject prefix would be 'cpufreq: imx6q: '
You can use 'git log' to find out what a proper prefix for a file/patch
should be.

>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/cpufreq/imx6q-cpufreq.c b/drivers/cpufreq/imx6q-cpufreq.c
> index 4b3f18e..2eea3d9 100644
> --- a/drivers/cpufreq/imx6q-cpufreq.c
> +++ b/drivers/cpufreq/imx6q-cpufreq.c
> @@ -166,6 +166,11 @@ static int imx6q_cpufreq_probe(struct platform_device *pdev)
>  		return -ENOENT;
>  	}
>  
> +	if (of_init_opp_table(cpu_dev)) {
> +		dev_err(cpu_dev,"failed to init OPP table\n");
> +		return -ENODEV;
> +	}
> +

Before doing that in the driver, you should check and make sure that
platform hasn't supply a opp table.

Shawn

>  	arm_clk = devm_clk_get(cpu_dev, "arm");
>  	pll1_sys_clk = devm_clk_get(cpu_dev, "pll1_sys");
>  	pll1_sw_clk = devm_clk_get(cpu_dev, "pll1_sw");
> -- 
> 1.8.3.2
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux