On Wednesday 11 December 2013 22:01:53 Sergei Shtylyov wrote: > Hello. > > On 27-11-2013 5:18, Laurent Pinchart wrote: > > This helps increasing build testing coverage. > > > > The driver doesn't compile on (at least) x86 due (possibly among others) > > to missing readsw/writesw I/O accessors, restrict compilation to SUPERH > > or ARM. > > > > Whether the CTL_DMA_ENABLE register is part of the standard TMIO > > controller or is Renesas-specific is unknown and impossible to test as > > we have no current or planned TMIO DMA users other than SUPERH and > > ARCH_SHMOBILE. Writing to the register is thus conditionally compiled > > for SUPERH and ARCH_SHMOBILE only. Adding ARCH_SHMOBILE_MULTI to the > > list would extend this to multiarch kernels, but would break the driver > > for non-shmobile platforms if the register is Renesas-specific. We can > > thus get rid of the conditional compilation completely without > > introducing any further issue, and let future non-Renesas users deal > > with the situation if it turns out to be a the problem. > > > > Cc: Chris Ball <cjb@xxxxxxxxxx> > > Cc: Guennadi Liakhovetski <g.liakhovetski@xxxxxx> > > Cc: Ian Molton <ian@xxxxxxxxxxxxxx> > > Cc: linux-mmc@xxxxxxxxxxxxxxx > > Signed-off-by: Laurent Pinchart > > <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> > > Acked-by: Simon Horman <horms@xxxxxxxxxxxx> > > --- > > > > drivers/mmc/host/Kconfig | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig > > index 7fc5099..ca1315e 100644 > > --- a/drivers/mmc/host/Kconfig > > +++ b/drivers/mmc/host/Kconfig > > @@ -479,7 +479,8 @@ config MMC_TMIO > > > > config MMC_SDHI > > > > tristate "SH-Mobile SDHI SD/SDIO controller support" > > > > - depends on SUPERH || ARCH_SHMOBILE > > + depends on SUPERH || ARM > > + depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST > > Hm, why 2 "depends" lines with SUPERH in both? The first line means "this driver requires SUPERH || ARM to be compiled", while the second line means "devices supported by this driver are only found on SUPERH || ARCH_SHMOBILE platforms". -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
