Dear Seungwon
On Thu, Dec 5, 2013 at 10:00 PM, Seungwon Jeon <tgih.jun@xxxxxxxxxxx> wrote:
>> +static DEFINE_SPINLOCK(mmc_tuning_lock);
> Can the above variables be involved in dw_mci_k3_priv_data instead of global declaration?
>
Unfortunately, this can be be put in priv_data, which is different
instance for different controller.
Here need protect register shared by different controllers
>> +static int dw_mci_k3_setup_clock(struct dw_mci *host)
>> +{
>> + dw_mci_k3_tun(host, MMC_TIMING_LEGACY);
> Is it necessary here?
> When card-init, MMC_TIMING_LEGACY will be passed via dw_mci_k3_set_ios().
Read register will fail if not set these register earlier, and set_ios
is too late.
Same reason for resume.
Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
