On 11/07/2013 06:59 PM, Arend van Spriel wrote: > When the host->tuning_count is zero it means that the If the tuning_count is zero, then the retuning timer shouldn't be started in the first place and not possible to run code there. Or is the tuning_count dynamically changed? Thanks, Aaron > retuning is disabled. Doing a mod_timer() with a zero > tuning_count does something else. > > Signed-off-by: Arend van Spriel <arend@xxxxxxxxxxxx> > --- > drivers/mmc/host/sdhci.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c > index 7a7fb4f..9803e7a 100644 > --- a/drivers/mmc/host/sdhci.c > +++ b/drivers/mmc/host/sdhci.c > @@ -2007,7 +2007,8 @@ out: > } else { > host->flags &= ~SDHCI_NEEDS_RETUNING; > /* Reload the new initial value for timer */ > - if (host->tuning_mode == SDHCI_TUNING_MODE_1) > + if (host->tuning_count && > + host->tuning_mode == SDHCI_TUNING_MODE_1) > mod_timer(&host->tuning_timer, jiffies + > host->tuning_count * HZ); > } > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html