Hello Teppei Kamijou,
This is a semi-automatic email about new static checker warnings.
The patch eae309836509: "mmc: sh_mmcif: Terminate DMA transactions
when detecting timeout or error" from Dec 12, 2012, leads to the
following Smatch complaint:
drivers/mmc/host/sh_mmcif.c:1122 sh_mmcif_end_cmd()
error: we previously assumed 'host->chan_rx' could be null (see line 1105)
drivers/mmc/host/sh_mmcif.c
1104 if (data->flags & MMC_DATA_READ) {
1105 if (host->chan_rx)
^^^^^^^^^^^^^
Existing check.
1106 sh_mmcif_start_dma_rx(host);
1107 } else {
1108 if (host->chan_tx)
1109 sh_mmcif_start_dma_tx(host);
1110 }
1111
1112 if (!host->dma_active) {
1113 data->error = sh_mmcif_data_trans(host, host->mrq, cmd->opcode);
1114 return !data->error;
1115 }
1116
1117 /* Running in the IRQ thread, can sleep */
1118 time = wait_for_completion_interruptible_timeout(&host->dma_complete,
1119 host->timeout);
1120
1121 if (data->flags & MMC_DATA_READ)
1122 dma_unmap_sg(host->chan_rx->device->dev,
^^^^^^^^^^^^^^^^^^^^^^^^^
Patch introduces new unchecked dereference.
Same thing for chan_tx as well.
1123 data->sg, data->sg_len,
1124 DMA_FROM_DEVICE);
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
