On Mon, Oct 28, 2013 at 06:20:41PM -0500, Rob Herring wrote: > On 10/15/2013 02:08 PM, Soren Brinkmann wrote: > > Add a driver for Arasan's SDHCI controller core. > > > > Signed-off-by: Soren Brinkmann <soren.brinkmann@xxxxxxxxxx> > > --- > > .../devicetree/bindings/mmc/arasan,sdhci.txt | 23 +++ > > MAINTAINERS | 1 + > > drivers/mmc/host/Kconfig | 12 ++ > > drivers/mmc/host/Makefile | 1 + > > drivers/mmc/host/sdhci-of-arasan.c | 224 +++++++++++++++++++++ > > 5 files changed, 261 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/mmc/arasan,sdhci.txt > > create mode 100644 drivers/mmc/host/sdhci-of-arasan.c > > > > diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt > > new file mode 100644 > > index 000000000000..20f0fc25e270 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt > > @@ -0,0 +1,23 @@ > > +Device Tree Bindings for the Arasan SDCHI Controller > > + > > + The bindings follow the mmc[1] and the clock bindings[2]. Only deviations are > > + documented here. > > + > > + [1] Documentation/devicetree/bindings/mmc/mmc.txt > > + [2] Documentation/devicetree/bindings/clock/clock-bindings.txt > > + > > +Required Properties: > > + - compatible: Compatibility string. Must be 'arasan,sdhci' > > This string is a bit non-specific. Vendor IP typically has configurable > options, different revs of IP with fixes/differences, and the > possibility of integration wierdness or bugs. So it is better to be as > specific as possible in case the kernel needs to know exactly what > version of h/w this is. Okay. The Zynq TRM specifies the version as '8.9A_apr02nd_2010', which seems a little overly specific to me. How does 'arasan,sdhci-8.9a' sound to you? Thanks, Sören -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
