Hi Chris,
Thanks for the feedback.
Do you have a way for me to compile the driver for all the architectures
impacted by the patch? So I could send a patch which compile for all
these architectures.
Cordially,
Jeremie
--
Jeremie Samuel Parrot S.A.
Software Engineer 14, quai de Jemmapes
R&D/OS Platform 75010 Paris, France
http://www.parrot.com
On 21/10/2013 03:49, Chris Ball wrote:
Hi Jeremie,
On Wed, Oct 16 2013, Jeremie Samuel wrote:
The driver can happily live without an atomic context and tasklets,
so turn the tasklets into the work structs.
Tasklets handlers still grab irqsave spinlocks, but we'll deal
with it in a separate patch.
Patch based on:http://thread.gmane.org/gmane.linux.kernel.mmc/2579.
Signed-off-by: Anton Vorontsov<avorontsov@xxxxxxxxxx>
Signed-off-by: Jeremie Samuel<jeremie.samuel.ext@xxxxxxxxxx>
[..]
diff --git a/include/linux/mmc/sdhci.h b/include/linux/mmc/sdhci.h
index 2b0f4f3..05cd76c 100644
--- a/include/linux/mmc/sdhci.h
+++ b/include/linux/mmc/sdhci.h
@@ -161,8 +161,8 @@ struct sdhci_host {
dma_addr_t adma_addr; /* Mapped ADMA descr. table */
dma_addr_t align_addr; /* Mapped bounce buffer */
- struct tasklet_struct card_tasklet; /* Tasklet structures */
- struct tasklet_struct finish_tasklet;
+ struct work_struct card_detect_work;
+ struct work_struct finish_work;
More compile errors:
λ git grep card_tasklet drivers/mmc/host
drivers/mmc/host/sdhci-bcm-kona.c: * to generate the CD IRQ handled in sdhci.c which schedules card_tasklet.
drivers/mmc/host/sdhci-dove.c: tasklet_schedule(&host->card_tasklet);
drivers/mmc/host/sdhci-s3c.c: tasklet_schedule(&host->card_tasklet);
drivers/mmc/host/sdhci-spear.c: tasklet_schedule(&host->card_tasklet);
Thanks,
- Chris.
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
