On Tue, Oct 15, 2013 at 03:36:32PM +0800, Dong Aisheng wrote: > On Mon, Oct 14, 2013 at 04:23:39PM +0800, Shawn Guo wrote: > > When I was reviewing Dong's imx6sl standard tuning patches, I found that > > it's a little clumsy to use enum imx_esdhc_type for handling features > > and quirks on different esdhc variants. > > > > Instead, the approach used in > > fec driver (drivers/net/ethernet/freescale/fec_main.c) should be more > > scalable in the long run. It defines flags for all those features and > > quirks and creates a mapping between esdhc variant and the flags. > > > > It cause troubles if i try to rebase my patch series based on it > because esdhc/usdhc also have a lot register difference. > > Originally we could simply use is_imx*_usdhc to handle those tiny difference, Okay. After you demonstrate those register differences we will need to handle, I agree that is_imx*_usdhc() thing might be more handy than flags for handling those tiny register differences. So I will respin the series to create flags only for those features, quirk, errata such things and leave the register differences to be handled by is_imx*_usdhc(). Shawn -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
