Am Montag, den 14.10.2013, 16:23 +0800 schrieb Shawn Guo: > When I was reviewing Dong's imx6sl standard tuning patches, I found that > it's a little clumsy to use enum imx_esdhc_type for handling features > and quirks on different esdhc variants. Instead, the approach used in > fec driver (drivers/net/ethernet/freescale/fec_main.c) should be more > scalable in the long run. It defines flags for all those features and > quirks and creates a mapping between esdhc variant and the flags. > > Actually, sdhci-esdhc-imx driver already has one such flag, i.e. > ESDHC_FLAG_MULTIBLK_NO_INT, but there is currently an unnecessary > translation between the flag and imx_esdhc_type. The series creates > another 3 flags and identify features/quirks using these flags and then > eliminate enum imx_esdhc_type completely. > Other than the comment on patch 2 this series, with the addition of patch 6/6 is Reviewed-by: Lucas Stach <l.stach@xxxxxxxxxxxxxx> > Shawn Guo (5): > mmc: sdhci-esdhc-imx: add flag ESDHC_FLAG_NO_DMAS_BITS > mmc: sdhci-esdhc-imx: add flag ESDHC_FLAG_ENGCM07207 > mmc: sdhci-esdhc-imx: add flag ESDHC_FLAG_USDHC > mmc: sdhci-esdhc-imx: pdev->id_entry should be immutable > mmc: sdhci-esdhc-imx: eliminate enum imx_esdhc_type > > drivers/mmc/host/sdhci-esdhc-imx.c | 108 +++++++++++++++--------------------- > 1 file changed, 45 insertions(+), 63 deletions(-) > -- Pengutronix e.K. | Lucas Stach | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-5076 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
