On 26 September 2013 17:40, Nicolas Pitre <nicolas.pitre@xxxxxxxxxx> wrote: > On Thu, 26 Sep 2013, Ulf Hansson wrote: > >> Suspend and resume of cards are handled by the protocol layer and >> consequently the mmc_suspend|resume_host APIs are marked as deprecated. > > Having the protocol layer take care of card suspend is perfectly sound. > > However, what about host controllers? Shouldn't they suspend themselves > as well? There is certainly potential for power saving by gating clocks > to the host IP block or the like. > Hi Nicolas, You are right, host drivers shall be responsible to handle power saving operations, like clocks, power domains, pinctrls, etc. In many cases I think using only runtime PM should satisfy a host driver's need to perform the proper power saving. For mvsdio, there were no host power save operations done in the suspend/resume callbacks, which is why I removed the callbacks entirely. Kind regards Ulf Hansson > > Nicolas -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html