On 17 September 2013 13:04, Mark Brown <broonie@xxxxxxxxxx> wrote: > On Tue, Sep 17, 2013 at 11:29:21AM +0200, Ulf Hansson wrote: > >> If you want to change voltage level for eMMC, both VCC and VCCQ must >> be possible to power cycle, unless you have a hw-reset wire connected >> to the eMMC which is implemented by a host->ops callback. This >> complicates things for SD/SDIO as well, while trying to setup the >> conditions for when to set the PWR_CYCLE flag. > > Should the hardware resets not be being converted over to be represented > as GPIOs (or the reset controller API) to factor things out? In some cases the power is controlled from inside the mmc controller, thus writing to some of it's registers will affect the power to the card. In other cases I believe we should be able to consider them as GPIOs. I think this is the reason to why a specific mmc host->ops is being used, to cover all cases. Maybe converting them to the "reset controller API" would be suitable for all cases, not sure. Note that, as of today only some sdhci variants have implemented the hw-reset support. Kind regards Ulf Hansson -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html