Re: [PATCH] mmc: atmel-mci: abort transfer on timeout error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/09/2013 17:29, ludovic.desroches@xxxxxxxxx :
From: Ludovic Desroches <ludovic.desroches@xxxxxxxxx>

When a software timeout occurs, the transfer is not stopped. In DMA case, it
causes DMA channel to be stuck because the transfer is still active causing
following transfers to be queued but not computed.

Cc: <stable@xxxxxxxxxxxxxxx> #3.9+
Signed-off-by: Ludovic Desroches <ludovic.desroches@xxxxxxxxx>

Acked-by: Nicolas Ferre <nicolas.ferre@xxxxxxxxx>

Thanks.

Reported-by: Alexander Morozov <etesial@xxxxxxxxx>
---
  drivers/mmc/host/atmel-mci.c | 7 +++++++
  1 file changed, 7 insertions(+)

diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c
index bdb84da..e9ea2fc 100644
--- a/drivers/mmc/host/atmel-mci.c
+++ b/drivers/mmc/host/atmel-mci.c
@@ -582,6 +582,13 @@ static void atmci_timeout_timer(unsigned long data)
  	if (host->mrq->cmd->data) {
  		host->mrq->cmd->data->error = -ETIMEDOUT;
  		host->data = NULL;
+		/*
+		 * With some SDIO modules, sometimes DMA transfer hangs. If
+		 * stop_transfer() is not called then the DMA request is not
+		 * removed, following ones are queued and never computed.
+		 */
+		if (host->state == STATE_DATA_XFER)
+			host->stop_transfer(host);
  	} else {
  		host->mrq->cmd->error = -ETIMEDOUT;
  		host->cmd = NULL;



--
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux