Hi,
On 08/30/2013 10:22 AM, Chris Ball wrote:
> Hi,
>
> On Fri, Aug 02 2013, Jaehoon Chung wrote:
>> Fixed the warning message.(clk_disable/enable didn't pair)
>> [..]
>>
>> Signed-off-by: Jaehoon Chung <jh80.chung@xxxxxxxxxxx>
>> Signed-off-by: Kyungmin Park <Kyungmin.park@xxxxxxxxxxx>
>> Acked-by: Heiko Stuebner <heiko@xxxxxxxxx>
>> Tested-by: Heiko Stuebner <heiko@xxxxxxxxx>
>> ---
>> Changelog v2:
>> - Added acked/tested by Heiko (on s3c2416)
>>
>> drivers/mmc/host/sdhci-s3c.c | 9 ---------
>> 1 file changed, 9 deletions(-)
>>
>> diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
>> index 6debda9..f974778 100644
>> --- a/drivers/mmc/host/sdhci-s3c.c
>> +++ b/drivers/mmc/host/sdhci-s3c.c
>> @@ -373,27 +373,18 @@ static struct sdhci_ops sdhci_s3c_ops = {
>> static void sdhci_s3c_notify_change(struct platform_device *dev, int state)
>> {
>> struct sdhci_host *host = platform_get_drvdata(dev);
>> -#ifdef CONFIG_PM_RUNTIME
>> - struct sdhci_s3c *sc = sdhci_priv(host);
>> -#endif
>> unsigned long flags;
>>
>> if (host) {
>> spin_lock_irqsave(&host->lock, flags);
>> if (state) {
>> dev_dbg(&dev->dev, "card inserted.\n");
>> -#ifdef CONFIG_PM_RUNTIME
>> - clk_prepare_enable(sc->clk_io);
>> -#endif
>> host->flags &= ~SDHCI_DEVICE_DEAD;
>> host->quirks |= SDHCI_QUIRK_BROKEN_CARD_DETECTION;
>> } else {
>> dev_dbg(&dev->dev, "card removed.\n");
>> host->flags |= SDHCI_DEVICE_DEAD;
>> host->quirks &= ~SDHCI_QUIRK_BROKEN_CARD_DETECTION;
>> -#ifdef CONFIG_PM_RUNTIME
>> - clk_disable_unprepare(sc->clk_io);
>> -#endif
>> }
>> tasklet_schedule(&host->card_tasklet);
>> spin_unlock_irqrestore(&host->lock, flags);
>
> Jaehoon/Heiko, it looks this patch was itself a bug fix -- can we
> not find a way to support cd-gpios and runtime PM at the same time?
I will check with slot-gpio.c. If it's working well, i think good that sdhci-s3c use it.
Then Patch v2 3/4~4/4 can be dropped. I will send the other patch series on this week.
Best Regards,
Jaehoon Chung
>
> Thanks,
>
> - Chris.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
