Re: [PATCH 1/3] mmc: sdhci-bcm-kona: Remove unneeded version.h inclusion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Christian,

On 22 August 2013 23:16, Christian Daudt <csd@xxxxxxxxxxxx> wrote:
> On 13-08-21 11:07 PM, Sachin Kamat wrote:
>>
>> On 20 July 2013 02:01, Christian Daudt <csd@xxxxxxxxxxxx> wrote:
>>>
>>> On 13-07-07 11:11 PM, Sachin Kamat wrote:
>>>>
>>>> version.h header inclusion is not necessary as detected by
>>>> versioncheck.
>>>>
>>>> Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx>
>>>> ---
>>>>    drivers/mmc/host/sdhci-bcm-kona.c |    1 -
>>>>    1 file changed, 1 deletion(-)
>>>>
>>>> diff --git a/drivers/mmc/host/sdhci-bcm-kona.c
>>>> b/drivers/mmc/host/sdhci-bcm-kona.c
>>>> index 87175f9..bca6d55 100644
>>>> --- a/drivers/mmc/host/sdhci-bcm-kona.c
>>>> +++ b/drivers/mmc/host/sdhci-bcm-kona.c
>>>> @@ -24,7 +24,6 @@
>>>>    #include <linux/of.h>
>>>>    #include <linux/of_device.h>
>>>>    #include <linux/of_gpio.h>
>>>> -#include <linux/version.h>
>>>>    #include <linux/mmc/slot-gpio.h>
>>>>      #include "sdhci-pltfm.h"
>>>
>>> Acked-by: Christian Daudt <csd@xxxxxxxxxxxx>
>>>
>>>   thanks,
>>>     csd
>>>
>>>
>> Ping Chris..
>>
>>
> Hi Sachin,
>  I can pull this one into bcm tree, as I already have other patches for that
> file in there. I'm also pulling in patch 3.

Sounds good. Please go ahead. Thanks.


Patch 2 was already covered by
> this commit which is already in my pull request to armsoc so I'll drop it:
> Author: Markus Mayer <markus.mayer@xxxxxxxxxx>
> Date:   Wed Aug 7 15:39:59 2013 -0700
>
>     mmc: sdhci-bcm-kona: make linker-section warning go away
>
>     This change makes the following build warning go away:
>     [...]
>       LINK    vmlinux
>       LD      vmlinux.o
>       MODPOST vmlinux.o
>     WARNING: modpost: Found 2 section mismatch(es).
>     To see full details build your kernel with:
>     'make CONFIG_DEBUG_SECTION_MISMATCH=y'
>
>     Signed-off-by: Markus Mayer <markus.mayer@xxxxxxxxxx>
>     Reviewed-by: Christian Daudt <csd@xxxxxxxxxxxx>
>     Reviewed-by: Matt Porter <matt.porter@xxxxxxxxxx>
>
>
>
>  thanks,
>    csd
>
>



-- 
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux