Re: [patch] mmc: sdhci-bcm-kona: '|' vs '&' typo

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 21, 2013 at 10:57:57AM +0200, walter harms wrote:
> 
> 
> Am 21.08.2013 10:24, schrieb Dan Carpenter:
> > The intent was to test if a flag was set.  In the current code the
> > conditions are always true.
> 
> I guess that it worked before ...
> That leaves the Question: are the tests needed at all ?

It's flagging everything as broken, and I presume that isn't good.
But on the other hand, these changes do occasionally break things
because now a lot of new untested code is used.  It really is a good
idea for someone to test this.

> > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> > ---
> > Static checker stuff.  Untested.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux