RE: [PATCH v2 1/1] mmc: dw_mmc: Add IDMAC 64-bit address mode support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jaehoon Chung,

>On 08/14/2013 09:51 AM, Jaehoon Chung wrote:
> Hi Prabu,
> 
> If IP version is the lower than 2.70a, 64bit address mode didn't support.
> How do you control on this case?
> (If CONFIG_MMC_DW_IDMAC_64BIT_ADDRESS is enabled and dw-mmc ip
> version is lower than 2.70a..)
It's a valid test case, thanks for reporting it.
I missed this condition check in my patch. Let me update it.

As per dw_mmc IP data book, the register offsets are different for both 32-bit and 64-bit configurations.
We can't use the driver in 32-bit address mode IDMAC if the driver was compiled with the CONFIG_MMC_DW_IDMAC_64BIT_ADDRESS since it will have the register offset corresponds to 64-bit configuration. 
So, If there is any mismatch between software and hardware configurations, then we should not use the internal DMA. I will add this condition check and send it. 

> And I think that some code should reuse the existing code..
Let me try to reuse the existing code as much as possible and create a new patch.

Thanks & regards,
Prabu Thangamuthu.
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux