On Fri, 2013-07-26 at 16:00 +0100, Pawel Moll wrote: > On Fri, 2013-07-26 at 15:49 +0100, Dinh Nguyen wrote: > > Dinh please... > > Uh, accept my apologies. I know exactly how it feels ;-) > > > > I've also noticed that Exynos defines almost identical bindings: > > > > > > > samsung,dw-mshc-ciu-div > > > > samsung,dw-mshc-sdr-timing > > > > samsung,dw-mshc-ddr-timing > > > > Yes, I agree. > > > > > > Aren't you both using the same "Synopsis Designware Mobile Storage Host > > > Controller" by any chance? Are you sharing a driver? And if not, > > > why? ;-) If the timings really must be parametrised, would it be > > > possible to come up with a common set of "synopsis" properties, instead > > > of "samsung" and "altr" ones? > > > > We are using the same driver. This is just a platform specifc entries > > for how the IP can be implemented. I also agree that we can come up with > > a shared set of properties for these. > > > > But since the platform-driver part has already been picked into the > > master tree, can I work on a common set after this patch? That way it > > enables SD/MMC to work on SocFPGA for the time being. > > Ah, I see. You should have included the binding documentation in the > driver using the bindings, not in the patch adding the required nodes to > DTS files... Than no one would have any comments on this patch ;-) > > So yes, if the driver part got merged I will shut up now, providing you > promise to work on "consolidating" the bindings for the next cycle. The > sooner, the better. Does it sound like a deal? Yes, you have my promise on the consolidating work! I was also thinking the same thing when I enabled this for SOCFPGA, but since I don't have any Exynos HW, I didn't have a way to test. But I will work on a patch soon and send to the Exynos people to test. Thanks, Dinh > > Pawel > > > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
