Re: 答复: [PATCH] Powerpc/t4240: change the compatible flags for t4240qds board

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/09/2013 10:41:22 PM, Zhang Haijun-B42677 wrote:
> No. It's still supposed to be describing the sdhc block itself, not the > board -- and any workarounds that key off of this will still fail to work
> with existing device trees.
[Haijun Wrote:] So, leave dts unchanged and to check compitable for board in sdhci-pltfm.c
e.g.:
	unsigned long root = of_get_flat_dt_root();

	if (of_flat_dt_is_compatible(root, "fsl,T4240QDS"))
		host->quirks |= XXX;

Why are you looking at the flat tree at this point? Use the normal OF accessors. The flat stuff is only for early boot.

Also make sure that you only do this for quirks that are actually board-specific. In your last patch you had two quirks keyed off of the board, one of which is keyed off of the SoC for other chips.

-SCott
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux