Chris, On Thu, Jun 27, 2013 at 9:44 AM, Chris Ball <cjb@xxxxxxxxxx> wrote: > This hunk breaks the build for me, because err_setup_bus and ret are > used in the error path of the call to mmc_add_host() in this function. > > I'll push a version that leaves those in. Let me know if you think > something strange is happening that made this work okay for you, like > a mismerge. WTF. OK, this is clearly my fault. I went back to the exact patch and it didn't compile for me, either. :( My typical workflow is to develop something in our local tree and then cherry-pick (and test!) on ToT linux. Probably what happened in this case was that there was a compile error and I didn't notice and somehow ended up testing my local tree (which doesn't error-check mmc_add_host). Sorry for the hassle. Leaving the err_setup_bus in is correct (and leaving the "ret" variable declared). I did those fixups and it now compiles and things boot. I haven't tested the deferral case in ToT yet, though. I'll try that now and post if something weird comes up. -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
