On Tue, Jun 04, 2013 at 12:49:57, Linus Walleij wrote: > On Tue, Jun 4, 2013 at 9:11 AM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > > On Fri, May 31, 2013 at 12:13 PM, Hebbar Gururaja > > <gururaja.hebbar@xxxxxx> wrote: > > > >> Amend the hsmmc controller to optionally take a pin control handle and > >> set the state of the pins to: > >> > >> - "default" on boot, resume and before performing a mmc transfer > >> - "idle" after initial default, after resume default, and after each > >> mmc/sd card access > >> - "sleep" on suspend() > >> > >> By optionally putting the pins into sleep state in the suspend callback > >> we can accomplish two things. > >> - One is to minimize current leakage from pins and thus save power, > >> - second, we can prevent the IP from driving pins output in an > >> uncontrolled manner, which may happen if the power domain drops the > >> domain regulator. > >> > >> If any of the above pin states are missing in dt, a warning message > >> about the missing state is displayed. > >> If certain pin-states are not available, to remove this warning message > >> pass respective state name with null phandler. > >> > >> Signed-off-by: Hebbar Gururaja <gururaja.hebbar@xxxxxx> > >> Cc: Balaji T K <balajitk@xxxxxx> > >> Cc: Chris Ball <cjb@xxxxxxxxxx> > >> Cc: linux-mmc@xxxxxxxxxxxxxxx > >> Cc: linux-omap@xxxxxxxxxxxxxxx > > > > This is perfectly correct. > > Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > > So please consider my other option given in patch 2 instead. I will check how I can be a part of this implementation > > Yours, > Linus Walleij > Regards, Gururaja -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
