Am Dienstag, 4. Juni 2013, 08:34:44 schrieb Linus Walleij: > On Mon, Jun 3, 2013 at 12:56 AM, Heiko Stübner <heiko@xxxxxxxxx> wrote: > > Currently the dw_apb_timer always expects a separate special timer to be > > availbable for the sched_clock. Some devices using dw_apb_timers do not > > have the sptimer but can use the clocksource as sched_clock. > > Therefore this patch adds using the clocksource timer as > > a fallback if no usable sched timer is found. > > > > Signed-off-by: Heiko Stuebner <heiko@xxxxxxxxx> > > Is this really what the patch does? I mean "ass the clocksourse as > fallback", it seems more like that is controlled from the device tree, > this looks more like some more careful handling of the device tree > input making the sched_timer optional, it doesn't really "add" > anything, does it? Right, the commit message is probably based a bit to much on the before-state of the driver, always expecting the "sptimer" and panicing if not found. How about: Currently the dw_apb_timer always expects a separate special timer to be availbable for the sched_clock. Some devices using dw_apb_timers do not have this sptimer but can use the clocksource as sched_clock instead. Therefore enable the driver to distiguish between devices with and without sptimer based on the devicetree data and select the correct timer as sched_clock. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html