On Monday, June 03, 2013 10:39 AM, Michał Mirosław wrote:
> On Sat, Jun 01, 2013 at 02:16:22PM +0900, Jingoo Han wrote:
> > Use the wrapper functions for getting and setting the driver data using
> > platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
> > so we can directly pass a struct platform_device.
> >
> > Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx>
> > ---
> > drivers/mmc/host/cb710-mmc.c | 2 +-
> > drivers/mmc/host/sh_mobile_sdhi.c | 6 +++---
> > 2 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/mmc/host/cb710-mmc.c b/drivers/mmc/host/cb710-mmc.c
> > index 777ca20..9d6e2b8 100644
> > --- a/drivers/mmc/host/cb710-mmc.c
> > +++ b/drivers/mmc/host/cb710-mmc.c
> > @@ -703,7 +703,7 @@ static int cb710_mmc_init(struct platform_device *pdev)
> > if (!mmc)
> > return -ENOMEM;
> >
> > - dev_set_drvdata(&pdev->dev, mmc);
> > + platform_set_drvdata(pdev, mmc);
> >
> > /* harmless (maybe) magic */
> > pci_read_config_dword(chip->pdev, 0x48, &val);
>
> You missed the counterpart - cb710_slot_to_mmc() in cb710-mmc.h.
> After the fix:
Oh, thank you for your comment. :)
I will fix and send v2 patch soon.
Thank you.
Best regards,
Jingoo Han
>
> Acked-by: Michał Mirosław <mirq-linux@xxxxxxxxxxxx>
> [for cb710]
>
> Best Regards,
> Michał Mirosław
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
