> >>
> >> Maybe I make misunderstood, or do some mistake.
> >> since CONFIG_MMC_UNSAFE_RESUME has to be set, is that mean sd card can not
> >> be unpluged with the feature enabled.
> >> It can be reproduced here if unplug card in suspend or not.
> >>
> >> static void mmc_sd_detect(struct mmc_host *host)
> >> {
> >> err = _mmc_detect_card_removed(host);
> >>
> >> if (err) {
> >> mmc_sd_remove(host);
> >> /* host -> card is NULL now */
> >> mmc_get_card(host->card);
> >> }
> >>
> >
> > I have no idea how you applied and tested this patch, but it seems
> > like you have screwed it up. The above code is aligned with this
> > patch.
>
> Sorry, the above code is NOT aligned with the code in this patch.
>
> >
> > mmc_get_card is called before "err = _mmc_detect_card_removed(host)".
> > And mmc_put_card, immediately after "err =
> > _mmc_detect_card_removed(host)".
> >
> > Please consider re-applying the patch and re-test.
The patches works fine.
I am sorry, my mistake.
When back-port to 3.9, some mess up :(
Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
