* Balaji T K <balajitk@xxxxxx> [130523 09:13]: > On Thursday 16 May 2013 09:46 PM, Tony Lindgren wrote: > > > >These before and after functions should be first converted to just usual > >regulator_set_voltage() eventually. In the PBIAS case it's really a mux > >plus a comparator, but we can set it up as a regulator. And on some boards > >it can be an external regulator like we have the legacy callbacks for in > >mach-omap2/hsmmc.c. > > Agree these .before, .after functions are for dual volt pbias i/o cell programming > based on regulator voltage, but modeling pbias register programming via > regulator might be overdo Probably not as then you don't need to export any custom functions from the pbias code. > >This all we can simplify quite a bit by defining the PBIAS register > >as pinctrl-single,bits with two different named modes. One for > >1.8V and for 3.3V. This way the PBIAS register is abstracted for > >various omaps in the .dts file as the register is different. > > > > Sometimes pbias register (like in omap3) has bits fields other than mmc1 pbias bits, > in which case it will be difficult to abstract via pinctrl-single > with mask bits for non-mmc1 pbias bits. Yes exactly, that's what you can totally define with pinconf-single,bits in omap3.dtsi and omap4.dtsi files. Then from the pbias handling regulator code you just request named pinctrl states which are now the same from pbias driver point of view. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
