Hi Arnd,
Thanks for the review.
On 05/15/2013 08:25 AM, Arnd Bergmann wrote:
> On Wednesday 15 May 2013, dinguyen@xxxxxxxxxx wrote:
>> +
>> +#define SYSMGR_SDMMCGRP_CTRL_OFFSET 0x108
>> +#define DRV_CLK_PHASE_SHIFT_SEL_MASK 0x7
>> +#define SYSMGR_SDMMC_CTRL_SET(smplsel, drvsel) \
>> + ((((drvsel) << 0) & 0x7) | (((smplsel) << 3) & 0x38))
>> +
>> +extern void __iomem *sys_manager_base_addr;
>
> This is not acceptable, you cannot just reference external symbols
> from one driver in another, without a proper interface.
>
> Please explain what the functionality is that you need here, then
> we can help you find the proper interface. My guess is that you
> need either the functionality provided by drivers/reset/
> or drivers/mfd/syscon.c.
Our implementation has the timing controls for the SD/MMC controller in
another custom IP block(system manager). sys_manager_base_addr was
mapped in mach-socfpga/socfpga.c. I saw the same approach with
drivers/clk(clk_mgr_base_addr), so I thought it would be ok with this
driver. Please advise on another way to do this...
>
>> + if (of_property_read_u32(dev->of_node, "pwr-en", &pwr_en)) {
>> + dev_info(dev, "couldn't determine pwr-en, assuming pwr-en = 0\n");
>> + pwr_en = 0;
>> + }
>> +
>> + /* Set PWREN bit */
>> + mci_writel(host, PWREN, pwr_en);
>
> If you add new properties, you have to document them in
> Documentations/devicetree/bindings/*.
>
> What is the requirement for this property? Is there no way to
> automatically power the card on/off using the normal
> dw_mci_set_ios function?
Apologies...it wasn't there in 3.8. I will fix...
Thanks,
Dinh
>
> The rest of this patch looks ok to me.
>
> Arnd
>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
