Re: [PATCH 19/22] mmc: sdhci-spear: remove unnecessary platform_set_drvdata()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 6, 2013 at 12:07 PM, Jingoo Han <jg1.han@xxxxxxxxxxx> wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx>
> ---
>  drivers/mmc/host/sdhci-spear.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-spear.c b/drivers/mmc/host/sdhci-spear.c
> index 7ae5b3a..2dba9f8 100644
> --- a/drivers/mmc/host/sdhci-spear.c
> +++ b/drivers/mmc/host/sdhci-spear.c
> @@ -258,7 +258,6 @@ static int sdhci_probe(struct platform_device *pdev)
>         return 0;
>
>  set_drvdata:
> -       platform_set_drvdata(pdev, NULL);
>         sdhci_remove_host(host, 1);
>  free_host:
>         sdhci_free_host(host);
> @@ -278,7 +277,6 @@ static int sdhci_remove(struct platform_device *pdev)
>         int dead = 0;
>         u32 scratch;
>
> -       platform_set_drvdata(pdev, NULL);
>         scratch = readl(host->ioaddr + SDHCI_INT_STATUS);
>         if (scratch == (u32)-1)
>                 dead = 1;

Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux