On 00:29 Fri 10 May , Christian Daudt wrote: > Thanks for the feedback. > > On 13-05-08 11:35 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: > >On 22:55 Wed 08 May , Christian Daudt wrote: > >>Add SDHCI driver for the Broadcom 281xx SoCs. Also > >>add bindings for it into bcm281xx dts files. > >>Still missing: > >> - power managemement > >split the dts/dtsi in an other patch > ok. > >>Signed-off-by: Christian Daudt <csd@xxxxxxxxxxxx> > >> > >>diff --git a/arch/arm/configs/bcm_defconfig b/arch/arm/configs/bcm_defconfig > >>index e3bf2d6..65edf6d 100644 > >>--- a/arch/arm/configs/bcm_defconfig > >>+++ b/arch/arm/configs/bcm_defconfig > >>@@ -78,6 +78,13 @@ CONFIG_BACKLIGHT_LCD_SUPPORT=y > >> CONFIG_LCD_CLASS_DEVICE=y > >> CONFIG_BACKLIGHT_CLASS_DEVICE=y > >> # CONFIG_USB_SUPPORT is not set > >>+CONFIG_MMC=y > >>+CONFIG_MMC_UNSAFE_RESUME=y > >>+CONFIG_MMC_BLOCK_MINORS=32 > >>+CONFIG_MMC_TEST=y > >>+CONFIG_MMC_SDHCI=y > >>+CONFIG_MMC_SDHCI_PLTFM=y > >>+CONFIG_MMC_SDHCI_BCM_KONA=y > >> CONFIG_NEW_LEDS=y > >> CONFIG_LEDS_CLASS=y > >> CONFIG_LEDS_TRIGGERS=y > >>diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig > >>index d88219e..e067c5a 100644 > >>--- a/drivers/mmc/host/Kconfig > >>+++ b/drivers/mmc/host/Kconfig > >>@@ -238,6 +238,16 @@ config MMC_SDHCI_S3C_DMA > >> YMMV. > >>+config MMC_SDHCI_BCM_KONA > >>+ tristate "SDHCI support on Broadcom KONA platform" > >>+ depends on ARCH_BCM && MMC_SDHCI_PLTFM > >select MMC_SDHCI_PLTFM > >will be better > Ok - changed it. Why is the select is better than the depends ? so you do not need to enable MMC_SDHCI_PLTFM and you can drop one line in the savdefconfig if tomorrow you need regulator select it so a old defconfig will continue to work Best Regards, J. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
