On Tue, 2 Apr 2013 08:56:54 +0200
Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> wrote:
...
> > @@ -336,6 +359,8 @@ static int mxcmci_setup_data(struct mxcmci_host *host, struct mmc_data *data)
> > } else {
> > host->dma_dir = DMA_TO_DEVICE;
> > slave_dirn = DMA_MEM_TO_DEV;
> > +
> > + mxcmci_fixup_buffers(data);
>
> For the register accesses it's fine the way you did in this version, but
> here I think a
>
> if (is_mpc512x_mmc())
> swap_buffer()
>
> would look better.
the swapping function uses optimised st_le32() which is not available
on ARM, that's the reason why this is build time selected. Maybe the
"fixup" in the function name is not pretty, I can change it to "swap"
then.
Thanks,
Anatolij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
