Hi, On Tue, Mar 12 2013, Chris Ball wrote: > On Tue, Mar 12 2013, Arnd Bergmann wrote: >>> Need add regulator_put here since regulator_get has succeed? >> >> Hmm, we still don't actually bail out if the error is encountered, so >> the reference count is balanced with the current patch, but I maybe >> a failed regulator_enable() should actually be a fatal error? > > The reason I didn't make it a fatal error is that this is just vqmmc > (responsible for moving from 3.3V to 1.8V for UHS modes), not the > main vmmc regulator. We can just disable those UHS modes from the > capabilities on the host if vqmmc is missing, or failed to enable, > or doesn't support those voltages, and that's what the code does now. I've pushed this patch to mmc-next for 3.10 now, let me know if you disagree. Thanks, - Chris. -- Chris Ball <cjb@xxxxxxxxxx> <http://printf.net/> One Laptop Per Child -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
