2013/3/11 Stephen Warren <swarren@xxxxxxxxxxxxx>: > On 03/08/2013 09:27 PM, Kevin Liu wrote: >> 2013/3/9 Stephen Warren <swarren@xxxxxxxxxxxxx>: >>> On 03/07/2013 09:52 PM, Kevin Liu wrote: >>>> commit 6c56e7a0 provide a function mmc_of_parse for standard MMC >>>> device-tree binding parser centrally. So just call it with >>>> sdhci_get_of_property together in sdhci_pltfm_register. >>> >>> BTW, this patch seems to do two unrelated things; firstly it changes the >>> indentation level throughout sdhci_get_of_property(), and secondly makes >>> the change described in the commit description. >> >> That's true. I originally want to do the first thing incidentally :-) >> So do you want to split this patch into two? > > It's Chris's call, but I think it'd be more usual to make this two > separate patches. Thanks for review! I have splited it into different patches as below: [PATCH v3 1/4] mmc: sdhci-pltfm: add calling mmc_of_parse in [PATCH 2/4] mmc: sdhci-pltfm: avoid indentation in Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html