Hi, On Fri, Mar 08 2013, Stephen Warren wrote: > On 03/08/2013 08:07 AM, Kevin Liu wrote: >> commit 6c56e7a0 provide a function mmc_of_parse for standard MMC >> device-tree binding parser centrally. So just call it with >> sdhci_get_of_property together in sdhci_pltfm_register. > >> diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c > >> @@ -212,6 +213,7 @@ int sdhci_pltfm_register(struct platform_device *pdev, >> if (IS_ERR(host)) >> return PTR_ERR(host); >> >> + mmc_of_parse(host->mmc); > > A few drivers already call mmc_of_parse() themselves. This change will > make that call happen twice. Mostly this won't be an issue, but there > are a couple gpio_request() calls in there, the error-handling for which > in mmc_of_parse() will spew error messages if attempted twice. Thanks for noticing that. We'll have to remove those mmc_of_parse() calls at the same time, if we want to do this. > have a patch in the Tegra tree that adds a call to mmc_of_parse() into > the Tegra driver, and that relies on fixing some bugs in the device > tree; the CD GPIO polarity was previously specified incorrectly in the DT... > > I guess to resolve this, what I could do is as follows: > > a) Create a topic branch in the Tegra tree that contains just the DT > fixes that mmc_of_parse() relies on for Tegra. > > b) Have Chris merge that into the MMC tree. > > c) Then, it's safe to move the Tegra driver patch out of the Tegra tree > into the MMC tree, so this issue can be addressed there. Equally, if the > merge in (b) above happens before this current patch is applied, this > current patch won't cause any breakage on Tegra. > > Chris, do you want to do this? Sure, that sounds fine. Thanks, - Chris. -- Chris Ball <cjb@xxxxxxxxxx> <http://printf.net/> One Laptop Per Child -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
