On Tue, Feb 12, 2013 at 05:08:44PM +0000, Vinod Koul wrote: > On Mon, Feb 04, 2013 at 02:47:02PM -0500, Matt Porter wrote: > > Add a dmaengine API to retrieve slave SG transfer capabilities. > > > > The API is optionally implemented by dmaengine drivers and when > > unimplemented will return a NULL pointer. A client driver using > > this API provides the required dma channel, address width, and > > burst size of the transfer. dma_get_slave_sg_caps() returns an > > SG caps structure with the maximum number and size of SG segments > > that the given channel can handle. > Okay this sounds much better :-) > > few points though: > - you added API for caps, but is actually calculating for given configuration > the max allowed range. IMHO that is not caps, perhaps renaming to get_max_sg > /some_better_name would be more apt. I went with get_slave_sg_limits(), seemed pretty descriptive. Just posted v4 with that change. > - Still I like the idea of caps, but it should give H/W support capablity. If > you want to add that, pls develop on same line... Ok, seems like a good separate submission. -Matt -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
