On 7 February 2013 21:00, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > On Thu, Feb 7, 2013 at 12:57 PM, Sachin Kamat <sachin.kamat@xxxxxxxxxx> wrote: > >> Added support for pin configuration using pinctrl subsystem. >> > > NACK. > > In the v3.9 merge window we will merge this patch: > http://marc.info/?l=linux-kernel&m=135887740715083&w=2 > > That should do the trick. Just define your tables properly. > Just a small clarification needed in this regard. On systems that do not use pinctrl and need to configure the gpios, we used to check the return value of devm_pinctrl_get_select_default() for error and then parse the dt file for gpios and configure them if needed. Now your latest patch "drivers/pinctrl: grab default handles from device core" suggests not to use boilerplate code as it will handle pinctrl configuration based on dt entries for it. So in the case like dw_mmc (in my patch above), please suggest best way to avoid parsing gpios from dt file in case where we have pinctrl defined. The following 3 lines (with +) wouldn't be required according to the patch and hence 'for' loop would get executed (which I want to avoid as the system supports pinctrl in this case). + pctrl = devm_pinctrl_get_select_default(host->dev); + if (!IS_ERR(pctrl)) + return 0; + /* cmd + clock + bus-width pins */ for (idx = 0; idx < NUM_PINS(bus_width); idx++) { gpio = of_get_gpio(slot_np, idx); -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
