Re: [PATCH 2/2] mmc: tegra: use mmc_of_parse to get the support of standard MMC DT bindings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2013-02-22 at 06:44 +0800, Guennadi Liakhovetski wrote:
> Hi Joseph
> 
> On Wed, 20 Feb 2013, Joseph Lo wrote:
> >  static int tegra_sdhci_buswidth(struct sdhci_host *host, int bus_width)
> >  {
> > -	struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
> > -	struct sdhci_tegra *tegra_host = pltfm_host->priv;
> >  	u32 ctrl;
> >  
> >  	ctrl = sdhci_readb(host, SDHCI_HOST_CONTROL);
> > -	if (tegra_host->is_8bit && bus_width == MMC_BUS_WIDTH_8) {
> > +	if (host->mmc->caps == MMC_CAP_8_BIT_DATA &&
> 
> Don't you want to check for just one bit? -Šcaps can contain multiple 
> flags set:
> 
> +	if ((host->mmc->caps & MMC_CAP_8_BIT_DATA) &&
> 
Ah, yes. Thanks for your review.

Joseph


--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux