On 02/20/2013 07:23 PM, Joseph Lo wrote: > On Thu, 2013-02-21 at 01:07 +0800, Stephen Warren wrote: >> On 02/20/2013 12:05 AM, Joseph Lo wrote: >>> Updating the sdhci-tegra driver to use mmc_of_parse to support standard >>> MMC DT bindings. Then we can remove the redundant code that already support >>> @@ -220,15 +203,12 @@ static void sdhci_tegra_parse_dt(struct device *dev, >>> struct sdhci_tegra *tegra_host) >>> { >> ... >>> + struct sdhci_host *host; >> ... >>> + host = platform_get_drvdata(to_platform_device(dev)); >>> + mmc_of_parse(host->mmc); >>> } >> >> It might be simpler to change the function prototype to simply pass in >> the host object too. > > It's a interface problem that I can't fix now. If sdhci core is going to > integrate mmc_of_parse into sdhci_get_of_property and mmc_gpio_get_ro > into somethere sdhci_do_get_ro, then we can refine later. I meant to change the prototype of sdhci_tegra_parse_dt(). It would be simple to change that function in this patch. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html