On 1/31/2013 1:50 PM, Manjunathappa, Prakash wrote: > Do not return probe failure with missing DMA resources, > allow driver to work in PIO mode. > Tested on da850-evm. It will be nice to mention what exactly was tested. rootfs mount? file create/deletion? mount/unmount? > Signed-off-by: Manjunathappa, Prakash <prakash.pm@xxxxxx> > --- > drivers/mmc/host/davinci_mmc.c | 10 ++++++---- > 1 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c > index 2063677..382b79d 100644 > --- a/drivers/mmc/host/davinci_mmc.c > +++ b/drivers/mmc/host/davinci_mmc.c > @@ -1190,13 +1190,15 @@ static int __init davinci_mmcsd_probe(struct platform_device *pdev) > > r = platform_get_resource(pdev, IORESOURCE_DMA, 0); > if (!r) > - goto out; > - host->rxdma = r->start; > + dev_warn(&pdev->dev, "DMA resource not specified\n"); Why not be specific and call it "RX DMA" instead. Anyone who gets this error will have to do that anyway since you have now got two identical error messages. > + else > + host->rxdma = r->start; > > r = platform_get_resource(pdev, IORESOURCE_DMA, 1); > if (!r) > - goto out; > - host->txdma = r->start; > + dev_warn(&pdev->dev, "DMA resource not specified\n"); "TX DMA" here. Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
