On Wednesday 30 January 2013, Guennadi Liakhovetski wrote: > > This means, that a multi-platform driver like, e.g. SDHCI cannot use the > > gpio "flags" cell and has to fall-back to always use "*-inverted" > > properties. Same holds for any other multi-arch driver, using GPIOs. So, > > we're stuck with this? But the SDHCI driver itself would not interpret the flags anyway, would it? >From the code, I understand that of_get_named_gpio() would return a gpio line with the polarity already inverted if it's specified that way, and the SDHCI_QUIRK_INVERTED_WRITE_PROTECT flag can be used to invert it independent of it. So you could actually express the same thing by either putting the inversion into the gpio specifier or into the *-inverted properties. If you actually provide both, that would have the same meaning as not inverting. > BTW, just verified in the current "next": all platforms, using cd-inverted > or wp-inverted in the mainline > > arch/arm/boot/dts/ccu9540.dts > arch/arm/boot/dts/ea3250.dts > arch/arm/boot/dts/phy3250.dts > arch/arm/boot/dts/snowball.dts > arch/arm/boot/dts/u9540.dts > > use GPIO controllers with 2 or 3 cells. What about those that don't use a GPIO line at all but instead use a built-in write-protect and card-detect registers of the SDHCI controller? The Freescale ESDHC on powerpc mpc83xx seems to do that, and require the wp-inverted flag. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
