On 01/28/2013 11:27 AM, Lars-Peter Clausen wrote:
> Quite a few drivers have a implementation of the get_timeout_clock callback
> which simply returns the result of clk_get_rate on devices clock. This patch
> adds a common implementation of this to the sdhci-pltfm module and replaces all
> custom implementations with the common one.
>
> Signed-off-by: Lars-Peter Clausen <lars@xxxxxxxxxx>
> ---
> I've only runtime tested this patch on a platform which is not yet upstream. For
> the drivers which are modified in this patch I've only done compile time
> testing. But I think all changes, but maybe the bcm2835 one, are straight
> forward.
It seems to work fine for bcm2835. So,
Tested-by: Stephen Warren <swarren@xxxxxxxxxxxxx>
> @@ -148,9 +131,9 @@ static struct sdhci_ops bcm2835_sdhci_ops = {
> .read_l = bcm2835_sdhci_readl,
> .read_w = bcm2835_sdhci_readw,
> .read_b = bcm2835_sdhci_readb,
> - .get_max_clock = bcm2835_sdhci_get_max_clock,
> + .get_max_clock = sdhci_pltfm_clk_get_max_clock,
> .get_min_clock = bcm2835_sdhci_get_min_clock,
> - .get_timeout_clock = bcm2835_sdhci_get_timeout_clock,
> + .get_timeout_clock = sdhci_pltfm_clk_get_max_clock,
> };
Rather than requiring .get_max_clock and .get_timeout_clock to be set by
each driver, perhaps the SDHCI core can call
sdhci_pltfm_clk_get_max_clock() if the function pointer is NULL?
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
