Re: [PATCH v5] mmc: fix async request mechanism for sequential read scenarios

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Konstantin,

On Fri, Dec 28 2012, Seungwon Jeon wrote:
> I checked the changes. Thanks for your work.
>
> Reviewed-by: Seungwon Jeon <tgih.jun@xxxxxxxxxxx>
>
> On Wednesday, December 26, 2012, Konstantin Dorfman wrote:
>> When current request is running on the bus and if next request fetched
>> by mmcqd is NULL, mmc context (mmcqd thread) gets blocked until the
>> current request completes. This means that if new request comes in while
>> the mmcqd thread is blocked, this new request can not be prepared in
>> parallel to current ongoing request. This may result in delaying the new
>> request execution and increase it's latency.
>> 
>> This change allows to wake up the MMC thread on new request arrival.
>> Now once the MMC thread is woken up, a new request can be fetched and
>> prepared in parallel to the current running request which means this new
>> request can be started immediately after the current running request
>> completes.
>> 
>> With this change read throughput is improved by 16%.
>> 
>> Signed-off-by: Konstantin Dorfman <kdorfman@xxxxxxxxxxxxxx>
>> ---
>> v5: 	- Removed BUG() and BUG_ON() with proper error handling
>> 	- Turn on of is_waiting_last_req flag moved from queue.c into
>> 	  block.c (mmc_blk_issue_req())
>>   	- mmc_init_context_info() called from mmc_add_card(). It is
>> 	  common point for MMC, SD, SDIO.

Thanks, pushed to mmc-next for 3.9.

Per, would you like to add an ACK here?

- Chris.
-- 
Chris Ball   <cjb@xxxxxxxxxx>   <http://printf.net/>
One Laptop Per Child
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux