On Tue, Dec 04, 2012 at 10:50:03PM +0800, Kevin Liu wrote:
> 2012/12/4 Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>:
> > + if (host->vmmc && regulator_get_voltage(host->vmmc) > 0) {
> > ret = regulator_is_supported_voltage(host->vmmc, 2700000,
> > 3600000);
> > if ((ret <= 0) || (!(caps[0] & SDHCI_CAN_VDD_330)))
> Good idea. But how about the regulator is disabled at this point? So I
> suggest to change to
> if (host->vmmc && regulator_get_voltage(host->vmmc) >= 0)
I'd not expect regulator_get_voltage() to return 0 for disabled
regulators, I'd expect it to return the voltage the regulator will have
when enabled.
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
