Re: [PATCH v3 1/4] mmc: dw-mmc: relocate the position called dw_mci_setup_bus()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 27, 2012 at 11:44 PM, Jaehoon Chung <jh80.chung@xxxxxxxxxxx> wrote:
> Hi,
>
> On 11/27/2012 04:58 PM, Seungwon Jeon wrote:
>> On Thursday, November 08, 2012, Jaehoon Chung <jh80.chung@xxxxxxxxxxx> wrote:
>>> To ensure the stable clock need to enable before set the DW_MMC_CARD_NEED_INIT flag.
>>> If set DW_MMC_CARD_NEED_INIT flag, wait for 80-clock before first command after power-up.
>> As we have discussed, the location of 'dw_mci_setup_bus' seems proper in 'dw_mci_set_ios'.
>> But commit message doesn't really hit me. Origin code can also ensure the same.
>> Mr. Newton, do you have any opinion?
> Origin code also ensure it. But it need to setup into set_ios.
> Because Operation related with clock is used with mmc_set_ios().
> And I didn't know why called the dw_mci_setup_bus() at every request.
>
> Best Regards,
> Jaehoon Chung

This looks ok to me (sorry for the delay, I've been away).

Acked-by: Will Newton <will.newton@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux