RE: [PATCH] Powerpc eSDHC: Convert the cmd_timeou_ms to u64 to avoid overflow

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi, Anton

This patch was for public C file. That was for different Host controller.
I think let them standalone will be better.

The u32 conversion will be removed.
Thanks. 


Regards
Haijun.


> -----Original Message-----
> From: Anton Vorontsov [mailto:cbouatmailru@xxxxxxxxx]
> Sent: Monday, November 26, 2012 5:12 PM
> To: Zhang Haijun-B42677
> Cc: linux-mmc@xxxxxxxxxxxxxxx; Huang Changming-R66093; Chris Ball
> Subject: Re: [PATCH] Powerpc eSDHC: Convert the cmd_timeou_ms to u64 to
> avoid overflow
> 
> On Mon, Nov 26, 2012 at 04:35:58PM +0800, Haijun Zhang wrote:
> > Convert the cmd_timeou_ms to u64 to avoid overflow
> >
> > Signed-off-by: Jerry Huang <Chang-Ming.Huang@xxxxxxxxxxxxx>
> > Signed-off-by: Haijun Zhang <Haijun.Zhang@xxxxxxxxxxxxx>
> 
> Reviewed-by: Anton Vorontsov <cbouatmailru@xxxxxxxxx>
> 
> But I think you should merge the two patches...
> 
> Thanks,
> 
> > CC: Chris Ball <cjb@xxxxxxxxxx>
> > ---
> >  drivers/mmc/card/block.c |    3 ++-
> >  1 files changed, 2 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c index
> > 21056b9..51903de 100644
> > --- a/drivers/mmc/card/block.c
> > +++ b/drivers/mmc/card/block.c
> > @@ -469,7 +469,8 @@ static int mmc_blk_ioctl_cmd(struct block_device
> *bdev,
> >  			 *     mrq.data = NULL;
> >  			 *     cmd.cmd_timeout = idata->ic.cmd_timeout_ms;
> >  			 */
> > -			data.timeout_ns = idata->ic.cmd_timeout_ms * 1000000;
> > +			data.timeout_ns = (u64)idata->ic.cmd_timeout_ms *
> > +						1000000;
> >  		}
> >
> >  		mrq.data = &data;
> > --
> > 1.7.0.4

��.n��������+%������w��{.n�����{��i��)��jg��������ݢj����G�������j:+v���w�m������w�������h�����٥



[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux