RE: [mmc:mmc-next 45/63] of_iommu.c:(.text+0x114dbc): undefined reference to `__aeabi_uldivmod'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





Regards
Haijun.


> -----Original Message-----
> From: linux-mmc-owner@xxxxxxxxxxxxxxx [mailto:linux-mmc-
> owner@xxxxxxxxxxxxxxx] On Behalf Of Fengguang Wu
> Sent: Monday, November 26, 2012 2:22 PM
> To: Zhang Haijun-B42677
> Cc: Huang Changming-R66093; linux-mmc@xxxxxxxxxxxxxxx; Chris Ball
> Subject: Re: [mmc:mmc-next 45/63] of_iommu.c:(.text+0x114dbc): undefined
> reference to `__aeabi_uldivmod'
> 
> I don't understand your question... The question is, did Chris use the
> same environment detailed in the original report? 

[Haijun: ] yes, I mean that if you use the same environment detailed in Chris's mail.
Including the config and the platform. No need yet, thank you anyway.

Did he check out the
> right commit (d29254e21ddddee37b3c8525817398d96d6403f3) and used the
> right config (omap2plus_defconfig)?
> 
> On Mon, Nov 26, 2012 at 06:12:24AM +0000, Zhang Haijun-B42677 wrote:
> > Thanks, Fengguang, did you use the same environment as Chris?
> > If so that's just the reason caused the err.
> >
> > Regards
> > Haijun.
> >
> >
> > > -----Original Message-----
> > > From: Fengguang Wu [mailto:fengguang.wu@xxxxxxxxx]
> > > Sent: Monday, November 26, 2012 2:03 PM
> > > To: Huang Changming-R66093
> > > Cc: Zhang Haijun-B42677; linux-mmc@xxxxxxxxxxxxxxx; Chris Ball
> > > Subject: Re: [mmc:mmc-next 45/63] of_iommu.c:(.text+0x114dbc):
> > > undefined reference to `__aeabi_uldivmod'
> > >
> > > On Mon, Nov 26, 2012 at 05:54:33AM +0000, Huang Changming-R66093
> wrote:
> > > > Hi, Robot
> > > > I don't find the `__aeabi_uldivmod' in branch 'mmc-next' of
> > > > linux-mmc
> > > tree.
> > > > Could you point out which file use it?
> > > >
> > > > This patch just use the 'div_u64' to calculate the timeout in
> > > > order to
> > > avoid overflow.
> > >
> > > Hi! This is confirmed to fix the problem:
> > >
> > > diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c index
> > > 48ad361..daf0636 100644
> > > --- a/drivers/mmc/host/omap.c
> > > +++ b/drivers/mmc/host/omap.c
> > > @@ -921,7 +921,7 @@ static inline void set_data_timeout(struct
> > > mmc_omap_host *host, struct mmc_reque
> > >  	u16 reg;
> > >
> > >  	cycle_ns = 1000000000 / host->current_slot->fclk_freq;
> > > -	timeout = req->data->timeout_ns / cycle_ns;
> > > +	timeout = div_u64(req->data->timeout_ns, cycle_ns);
> > >  	timeout += req->data->timeout_clks;
> > >
> > >  	/* Check if we need to use timeout multiplier register */
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at
> http://vger.kernel.org/majordomo-info.html


--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux