2012/11/18 Chris Ball <cjb@xxxxxxxxxx>: > Hi, > > On Wed, Oct 17 2012, Kevin Liu wrote: >> From: Kevin Liu <kliu5@xxxxxxxxxxx> >> >> Acked-by: Zhangfei Gao <zhangfei.gao@xxxxxxxxxxx> >> Signed-off-by: Kevin Liu <kliu5@xxxxxxxxxxx> >> --- >> drivers/mmc/host/sdhci-pxav3.c | 2 ++ >> include/linux/platform_data/pxa_sdhci.h | 2 ++ >> 2 files changed, 4 insertions(+), 0 deletions(-) > > It looks like you aren't using any of the quirks in quirks2, is that > right? I'm still hoping we might be able to get rid of quirks2, so > I'd rather wait until you need it (or we get rid of it) before applying > this. > My previous patch "[PATCH v6 08/14] mmc: sdhci: enhance preset value function" introduced a quirk SDHCI_QUIRK2_PRESET_VALUE_BROKEN, which aim to disable preset feature since the preset setting is fixed only for 200Mhz base clock on pxav3 platform. So we should disable preset if the base clock is other than 200Mhz. Thanks Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html