Re: [PATCH v3] MMC: SD/MMC Host Controller for Wondermedia WM8505/WM8650

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 2012-11-17 at 21:58 -0500, Chris Ball wrote:
> Hi Tony, thanks for the quick turnaround,
> 
> On Sat, Nov 17 2012, Tony Prisk wrote:
> > +	regular_irq = irq_of_parse_and_map(np, 0);
> > +	dma_irq = irq_of_parse_and_map(np, 1);
> > +
> > +	if ((!regular_irq) | (!dma_irq)) {
> > +		dev_err(&pdev->dev, "Getting IRQs failed!\n");
> 
> I think you meant ||, not |, and you could remove the redundant parens.
> 
> Other than that, I think this is ready -- if you want to ACK the above
> change I'll fold it in without having you resend the patch.
> 
> Thanks,
> 
> - Chris.

Oops - Good catch.
Acked-by: Tony Prisk <linux@xxxxxxxxxxxxxxx>

Regards
Tony P

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux