sdhci vccq regulator support drops UHS-I flags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Please check this commit:


commit 6231f3de1332b2a8a90e0c598ab6acc8f1eff7c1
Author: Philip Rakity <prakity@xxxxxxxxxxx>
Date:   Mon Jul 23 15:56:23 2012 -0700

    mmc: sdhci: Add regulator support for vccq (voltage regualor)

Particularly this hunk:

+       /* If vqmmc regulator and no 1.8V signalling, then there's no UHS */
+       host->vqmmc = regulator_get(mmc_dev(mmc), "vqmmc");
+       if (IS_ERR(host->vqmmc)) {
+               pr_info("%s: no vqmmc regulator found\n", mmc_hostname(mmc));
+               host->vqmmc = NULL;
+       }
+       else if (regulator_is_supported_voltage(host->vqmmc, 1800000, 1800000))
+               regulator_enable(host->vqmmc);
+       else
+               caps[1] &= ~(SDHCI_SUPPORT_SDR104 | SDHCI_SUPPORT_SDR50 |
+                      SDHCI_SUPPORT_DDR50);

One effect of this code is that if the system has no vqmmc regulator,
the UHS-I flags are always cleared on the final line, so the ultra
speed mode is always disabled.

Is this intentional or is there a check missing?

Thanks
Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux