Re: [PATCH] mmc: core: debugfs: Add signal_voltage to ios dump

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Fri, Oct 26 2012, Johan Rudholm wrote:
> 2012/10/26 Philip Rakity <prakity@xxxxxxxxxx>:
>>
>> On Oct 26, 2012, at 11:31 AM, Johan Rudholm
>> <johan.rudholm@xxxxxxxxxxxxxx> wrote:
>>
>>> +     default:
>>> +             str = "invalid";
>>
>> would "is unknown"  be a better str ?
>
> Maybe... Actually, I just followed the standard in the function, all
> other strings default to "invalid" when the definition is missing. So
> if I change this, then I should also change the rest of the strings in
> the function. I will do this if we think it's worth the effort, but is
> it?

Thanks, pushed to mmc-next for 3.8 -- let's handle string renaming
separately to this patch.

- Chris.
-- 
Chris Ball   <cjb@xxxxxxxxxx>   <http://printf.net/>
One Laptop Per Child
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux